Skip to content

Go through and re evaluate some tests#29

Merged
MDA2AV merged 1 commit intomainfrom
fix/reevaluate-tests
Feb 13, 2026
Merged

Go through and re evaluate some tests#29
MDA2AV merged 1 commit intomainfrom
fix/reevaluate-tests

Conversation

@MDA2AV
Copy link
Copy Markdown
Owner

@MDA2AV MDA2AV commented Feb 13, 2026

  1. COMP-ABSOLUTE-FORM is inverted vs RFC
    src/Http11Probe/TestCases/Suites/ComplianceSuite.cs:431 treats 400 as Pass and 2xx as Warn; glossary says the same at docs/content/docs/request-line/absolute-form.md:13.
    RFC 9112 says a server MUST accept absolute-form, so 400 should not be Pass.
  2. COMP-CHUNKED-EXTENSION is too lenient
    src/Http11Probe/TestCases/Suites/ComplianceSuite.cs:751 allows 400 as Pass; glossary mirrors this at docs/content/docs/body/chunked-extension.md:13.
    RFC 9112 §7.1.1 says recipients MUST ignore unrecognized chunk extensions; for this short valid extension payload, 400 is not a good pass outcome.
  3. SMUG-TE-TRAILING-SPACE is too strict
    src/Http11Probe/TestCases/Suites/SmugglingSuite.cs:140 only accepts 400/close; glossary same at docs/content/docs/smuggling/te-trailing-space.md:13.
    RFC 9110 §5.5 says trailing OWS is excluded before evaluating field value; plus RFC 9112 allows CL+TE requests to be rejected or processed with TE (with connection close). So 2xx (with
    close) should not be an automatic fail.
  4. SMUG-TE-OBS-FOLD is too strict
    src/Http11Probe/TestCases/Suites/SmugglingSuite.cs:1189 requires exact 400; glossary same at docs/content/docs/smuggling/te-obs-fold.md:13.
    RFC 9112 §5.2 allows two compliant server behaviors: reject with 400 or replace obs-fold with SP and continue parsing.
  5. SMUG-TE-XCHUNKED and SMUG-TE-IDENTITY reject 501 even though RFC allows it
    src/Http11Probe/TestCases/Suites/SmugglingSuite.cs:124 and src/Http11Probe/TestCases/Suites/SmugglingSuite.cs:819 only pass on 400/close.
    RFC 9112 §6.1 says unknown transfer coding SHOULD get 501 Not Implemented; that should be accepted (at least Warn/Pass).
  6. COMP-UPGRADE-INVALID-VER is narrower than its own glossary and RFC intent
    Code at src/Http11Probe/TestCases/Suites/ComplianceSuite.cs:773 effectively passes only 426 (or warns on 2xx) and fails other non-101 errors.
    Glossary says 426 or any non-101 at docs/content/docs/upgrade/upgrade-invalid-ver.md:13.
    RFC 6455 says abort handshake and send an appropriate HTTP error (e.g. 426), so other non-101 error codes should not fail by default.

Docs/Project consistency issues

  1. SMUG-CHUNKED-WITH-PARAMS is marked unscored in docs but scored in code
    docs/content/docs/smuggling/chunked-with-params.md:12 vs src/Http11Probe/TestCases/Suites/SmugglingSuite.cs:903 (no Scored = false).
  2. Glossary missing for implemented tests
    No dedicated glossary pages for: SMUG-CHUNK-EXT-CR, SMUG-TE-VTAB, SMUG-TE-FORMFEED, SMUG-TE-NULL, SMUG-TRAILER-AUTH (and baseline COMP-BASELINE).

@MDA2AV MDA2AV merged commit 4ad36c3 into main Feb 13, 2026
1 check failed
@MDA2AV MDA2AV deleted the fix/reevaluate-tests branch February 14, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant